react-native: fix invalid RN object returned from iOS BacktraceReactNative.initialize function #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ative.initialize function
konraddysput
approved these changes
Oct 23, 2024
| instance = [[BacktraceCrashReporter alloc] initWithBacktraceUrl:submissionUrl andDatabasePath: databasePath andAttributes: attributes andOomSupport:TRUE andAttachments:attachmentPaths]; | ||
| [instance start]; | ||
| return instance; | ||
| return nil; |
Collaborator
There was a problem hiding this comment.
do we need to return something from the function?
Contributor
Author
There was a problem hiding this comment.
nope, the return value is not used at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns
nilinstead ofinstancefromBacktraceReactNative.initialize, as theinstanceobject was impossible to serialize to JSON.https://reactnative.dev/docs/0.70/native-modules-ios#synchronous-methods