Skip to content

react-native: fix invalid RN object returned from iOS BacktraceReactNative.initialize function #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perf2711 merged 1 commit into from
Oct 24, 2024
Merged

react-native: fix invalid RN object returned from iOS BacktraceReactNative.initialize function #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ios/BacktraceReactNative.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ @implementation BacktraceReactNative
}
instance = [[BacktraceCrashReporter alloc] initWithBacktraceUrl:submissionUrl andDatabasePath: databasePath andAttributes: attributes andOomSupport:TRUE andAttachments:attachmentPaths];
[instance start];
return instance;
return nil;
Copy link
Collaborator

@konraddysput konraddysput Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to return something from the function?

Copy link
Contributor Author

@perf2711 perf2711 Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, the return value is not used at all.

}

RCT_EXPORT_METHOD(useAttachments: (NSArray*) attachmentPaths) {
Expand Down