create_jvm_test_suite: fail on empty tests list

[dmivankov]

native.test_suite will treat empty tests list as all tests in package https://bazel.build/reference/be/general#test_suite.tests which can be confusing, and likely pointing to a bug if test_suffixes or test file names, so failing instead makes sense

[gemini-code-assist]

Summary of Changes

Hello @dmivankov, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a safeguard within the create_jvm_test_suite Bazel rule. Its purpose is to make test suite definitions more robust by preventing silent misconfigurations where an empty test list could lead to an unintended "all tests in package" behavior. This change improves clarity and helps developers catch potential issues early.

Highlights

• Prevent unintended test suite behavior: The create_jvm_test_suite function now explicitly fails if the generated list of tests is empty. This prevents native.test_suite from implicitly including all tests in the package, which can be confusing and hide misconfigurations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a check to ensure that the list of tests for a create_jvm_test_suite is not empty. This is a valuable change as it prevents the native.test_suite from unexpectedly including all tests in the package, which is a confusing default behavior. The change correctly fails the build with a descriptive error message if no tests are found. I have one suggestion to make the error message even more helpful by including the name of the test suite.