Skip to content

create_jvm_test_suite: fail on empty tests list #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

create_jvm_test_suite: fail on empty tests list #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f00478
create_jvm_test_suite: fail on empty tests list
dmivankov Sep 11, 2025
dcd7fb8
Update java/private/create_jvm_test_suite.bzl
dmivankov Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/private/create_jvm_test_suite.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ def create_jvm_test_suite(
)
tests.append(test_name)

if not tests:
# test_suite with tests=[] would create a suite containing ALL tests in current package
# which would be confusing
fail("No tests found for suite '{}'. Do test files match 'test_suffixes'?".format(name))

native.test_suite(
name = name,
tests = tests,
Expand Down