Draft
Conversation
This commit adds a fork of the `markdown_editor_plus` library as a dependency, and adds a boolean property of `markdownEditor` to `CustomTextField`. When set to `true`, the `CustomTextField` renders a markdown editor inside the normal styled text field box.
|
Visit the preview URL for this PR (updated for commit f6257f0): https://gen-hls-bkc-7627--pr260-dk-feat-28-markdown-wgsacqar.web.app (expires Tue, 02 Dec 2025 02:32:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: eed668cca81618d491d024574a8f8a6003deaa8d |
Collaborator
Author
|
Just had a review resulting in this todo list:
|
14 tasks
Contributor
|
@dariusk I know we shelved this until you put the finishing touches on community admin, but just wanted to doublecheck whether the review checklist above is up to date with what you'll need to dive into when you circle back to it. (Totally fine if so, just wanted to make sure since that was posted a bit ago.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
This PR adds an option to
CustomTextFieldthat turns it into a markdown editor. The text field styling remains the same as always, there is just now a toolbar in the text field and you can apply markdown syntax and preview it.Fixes #28
Changes in the codebase
This PR adds a fork of the
markdown_editor_pluslibrary as a dependency, and adds a boolean property ofmarkdownEditortoCustomTextField. When set totrue, theCustomTextFieldrenders a markdown editor inside the normal styled text field box.CustomTextFieldbehavior still exists, it's just wrapped inif (!widget.markdownEditor)if (widget.markdownEditor)and calls aMarkdownAutoPreviewcomponent from the external library, passing in styling details so it remains consistent withChanges outside the codebase
markdown_editor_plusis AGPL-compatible so we are good on that frontTesting this PR
Additional information
I'd like a design review! Probably for the UI sync meeting this week.