Workaround a crash in macOS tahoe 26 / xcode 16.4+ #20146
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BD103
added
C-Bug
|
As a small note: the advisories CI failure is unrelated to this PR, so it can be ignored. |
|
I think this should be included in 0.17. It's a small change, and we don't want to crash on platforms we will need to support in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Workaround a crash in macOS tahoe 26, and newer xcode versions.
Fixes #19625, and see #19567
Solution
Disable debug assertions in objc2 untl winit has a new release enabling a more precise workaround.
Testing
cargo run --example breakoutgoes from crashing to working fine on the macOS tahoe beta.Alternative
A beta is a beta so maybe it's just not supported and we should just wait for the winit update. madsmtm/objc2#765 (comment) implies that an incoming xcode update has the same issue however so it might be more urgent.