Skip to content

Make RecordDiagnostics::time_span take CommandEncoder #21504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Make RecordDiagnostics::time_span take CommandEncoder #21504

wants to merge 3 commits into from
+26 −14

Conversation

akimakinai
Copy link
Contributor

Objective

Solution

  • Make RecordDiagnostics::time_span take CommandEncoder instead of being generic over command encoder or pass

Testing

  • cargo check passes

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change A-Diagnostics Logging, crash handling, error reporting and performance analysis D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 13, 2025
kristoff3r
kristoff3r reviewed Oct 16, 2025
View reviewed changes
crates/bevy_render/src/diagnostic/mod.rs Outdated
///
/// Returns a guard, which will panic on drop unless you end the span.
fn time_span<E, N>(&self, encoder: &mut E, name: N) -> TimeSpanGuard<'_, Self, E>
fn time_span<E, N>(&self, encoder: &mut CommandEncoder, name: N) -> TimeSpanGuard<'_, Self, E>
Copy link
Contributor

@kristoff3r kristoff3r Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand the context of this change, but I checked and the E is entirely unused after this, so it and the PhantomData should be removed from TimeSpanGuard.

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@kristoff3r kristoff3r kristoff3r left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

Rendering
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akimakinai @kristoff3r @alice-i-cecile