Skip to content

Allow DiagnosticsBuffer to be applied even if DiagnosticsStore is missing. #21550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow DiagnosticsBuffer to be applied even if DiagnosticsStore is missing. #21550

wants to merge 1 commit into from

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

  • Avoid panicking in DiagnosticsBuffer::apply if the world is missing the DiagnosticsStore.
  • Clear the buffer if DiagnosticsStore is missing to prevent growing the buffer.

Testing

  • None.

@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andriyDev