Remove queue text #22051
Remove queue text #22051
Conversation
… call the `update_buffer` and `update_text_layout_info` instead.
ickshonpe
added
C-Code-Quality
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
1 similar comment
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
| buffer.set_size(font_system, bounds.width, bounds.height); | ||
|
|
||
| // Workaround for alignment not working for unbounded text. | ||
| // See https://github.com/pop-os/cosmic-text/issues/343 |
There was a problem hiding this comment.
Should we have a bevy issue too to track this too?
There was a problem hiding this comment.
Well the workaround here works, so I don't see any need especially.
I suppose we could add a Blocked "remove-this-hack-when-cosmic-text-fixes-it-upstream" issue.
…ing text entities.
…into remove-queue-text
alice-i-cecile
added
S-Ready-For-Final-Review
|
This PR tanked the perfs of the noticed on https://metrics.bevy.org/stress-tests.html#176d5a39b7c146bc6885e095bd105871fba24054 
|
# Objective Fix performance regression caused by #22051 breaking text2d's change detection. Fixes #22099. ## Solution Set the text entity's `ComputedTextBlock::needs_rerender` flag to false at the start of `update_text_buffer` and `update_text_layout_info`. ## Testing ``` cargo run --example many_text2d --release ``` should run about 400x main's FPS
4 participants
Objective
Remove the
queue_textfunction as redundant.Solution
queue_textfromTextPipeline.update_text2d_layout, instead ofqueue_text, callTextPipeline::update_bufferand thenTextPipeline::update_text_layout.