Skip to content

remove empty_bind_group_layout #22068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 2 commits into from
Dec 9, 2025
Merged

remove empty_bind_group_layout #22068

mockersf merged 2 commits into from
Dec 9, 2025

Conversation

@ecoskey
Copy link
Contributor

@ecoskey ecoskey commented Dec 9, 2025

Objective

  • Now that we have BindGroupLayoutDescriptor, we don't need this ugly hack

Solution

  • Remove the ugly hack

@ecoskey ecoskey added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 9, 2025
@tychedelia tychedelia added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 9, 2025
@mockersf mockersf added this pull request to the merge queue Dec 9, 2025
Merged via the queue into bevyengine:main with commit 6684682 Dec 9, 2025
38 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+2 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@tychedelia tychedelia tychedelia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ecoskey @IceSentry @mockersf @tychedelia