Skip to content

Simplify ui_picking's camera search #22075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mockersf merged 2 commits into from
Dec 9, 2025
Merged

Simplify ui_picking's camera search #22075

mockersf merged 2 commits into from
Dec 9, 2025

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 9, 2025 •
edited
Loading

Objective

In ui_picking the camera_query iterator is run through multiple filters and maps, which could be replaced by a single filter. Also camera_query retrieves the Camera component but then it is thrown away and queried for again.

Solution

  • Just collapse all the maps and filters into one filter.
  • Only query for Camera once and keep the result, remove the second query.

@ickshonpe
In ui_picking the camera_query iterator is run through multiple fil…
dd2b58a 
…ters and maps which can be replaced by a single filter. Also camera_query retrieves the `Camera` component but then it is thrown away and queried for it again. Keep the first `Camera` result and remove the second query.
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change A-Picking Pointing at and selecting objects of all sorts D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 9, 2025
@mockersf mockersf enabled auto-merge December 9, 2025 11:32
auto-merge was automatically disabled December 9, 2025 11:37

Head branch was pushed to by a user without write access

@mockersf mockersf added this pull request to the merge queue Dec 9, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 9, 2025
Merged via the queue into bevyengine:main with commit 617828c Dec 9, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees

No one assigned

Labels

A-Picking Pointing at and selecting objects of all sorts A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ickshonpe @alice-i-cecile @mockersf