Skip to content

Conversation

@GideonBature
Copy link
Contributor

Description

This PR migrates our code coverage reporting from Coveralls to Codecov while maintaining all existing functionality.

Notes to the reviewers

Changelog notice

Changes

  • Updated workflow name: Changed from "Code Coverage" to reflect Codecov integration
  • Replaced coverage service: Switched from coverallsapp/github-action to codecov/codecov-action@v4
  • Enhanced permissions: Added necessary permissions for Codecov OIDC authentication:
    • contents: read
    • pull-requests: write
    • id-token: write
  • Improved configuration: Added Codecov-specific parameters:
    • use_oidc: true for secure tokenless authentication
    • fail_ci_if_error: false to prevent CI failures on upload issues
    • flags: rust for better organization
    • name: codecov-bdk-wallet for clear identification

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Closes #320

@codecov
Copy link

codecov bot commented Oct 8, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ValuedMammal ValuedMammal added this to the Wallet 3.0.0 milestone Oct 8, 2025
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet Oct 8, 2025
@ValuedMammal ValuedMammal added the github_actions Pull requests that update GitHub Actions code label Oct 8, 2025
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 36f98df

@GideonBature good work!

Confirmed codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 is tagged version 5.5.1

Also verified report correctly generated for @GideonBature's fork of bdk_wallet:
https://coveralls.io/jobs/173295208

@notmandatory notmandatory merged commit b0c1b72 into bitcoindevkit:master Nov 4, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Nov 4, 2025
@notmandatory
Copy link
Member

The published codecov report for bdk_wallet is here:
https://app.codecov.io/github/bitcoindevkit/bdk_wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ci: replace coveralls with codecov server

3 participants