Skip to content

fix: avoid error state for empty titled code reviews - #587

Merged
matt2e merged 1 commit into
mainfrom
empty-code-review-shows-as-error
Apr 8, 2026
Merged

fix: avoid error state for empty titled code reviews#587
matt2e merged 1 commit into
mainfrom
empty-code-review-shows-as-error

Conversation

@matt2e

@matt2e matt2e commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • treat empty code reviews with a title as successful instead of failed
  • extract the empty failed review check into shared review state logic
  • add tests covering titled and untitled empty reviews

@matt2e
matt2e requested review from baxen and wesbillman as code owners April 8, 2026 05:38
@matt2e
matt2e merged commit db184d2 into main Apr 8, 2026
5 checks passed
@matt2e
matt2e deleted the empty-code-review-shows-as-error branch April 8, 2026 05:54
loganj added a commit that referenced this pull request Apr 9, 2026
…ktree-dis

* origin/main: (45 commits)
  feat(penpal): persist recent files activity across restarts (#595)
  feat: persist open windows, tabs, and geometry across app restarts (#588)
  feat(staged): generate next prefill text when generating notes (#594)
  feat(staged): add "Run again" button to action output dialog (#593)
  feat: queue repo sessions in project MCP with async cancellation fix (#591)
  fix(staged): lowercase "building" subtitle for consistency (#592)
  fix(staged): use completedAt for commit prefill timeline ranking (#590)
  fix: add per-branch mutex to prevent worktree setup race condition (#589)
  feat: add diff commit session launcher (#585)
  fix: avoid error state for empty titled code reviews (#587)
  fix: cancel in-flight auto reviews before manual sessions (#584)
  feat(settings): add repo context search (#583)
  fix(staged): sort timeline items by completion time so queued items appear before completed ones (#568)
  fix: drain queued branch sessions from backend lifecycle (#579)
  fix: restore resume session metadata for resumed actions (#580)
  feat(staged): add purple diff comment theme (#578)
  fix(ui): hide branch actions during setup (#572)
  fix: validate parsed PR URLs before extraction (#577)
  fix: centralize staged relative time updates (#576)
  fix: avoid UI freezes when starting background sessions (#575)
  ...

# Conflicts:
#	apps/penpal/internal/watcher/watcher.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant