fix(staged): use completedAt for commit prefill timeline ranking - #590
Merged
Conversation
The commit prefill logic used createdAt to determine the latest timeline item, while the timeline display uses completedAt ?? createdAt. This caused the prefill to pick the wrong item when an earlier-created review completed after a note, showing note-based prefill instead of review-based. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matt2e
added a commit
that referenced
this pull request
Apr 9, 2026
Port the completedAt timeline ranking fix from #590 to use completedAt (falling back to createdAt) for review/note candidates. Also address code review feedback: add unit tests for extract_suggested_next_steps, return empty string for review mode prefill, and use .trim() for draft-clearing comparison. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
loganj
added a commit
that referenced
this pull request
Apr 9, 2026
…ktree-dis * origin/main: (45 commits) feat(penpal): persist recent files activity across restarts (#595) feat: persist open windows, tabs, and geometry across app restarts (#588) feat(staged): generate next prefill text when generating notes (#594) feat(staged): add "Run again" button to action output dialog (#593) feat: queue repo sessions in project MCP with async cancellation fix (#591) fix(staged): lowercase "building" subtitle for consistency (#592) fix(staged): use completedAt for commit prefill timeline ranking (#590) fix: add per-branch mutex to prevent worktree setup race condition (#589) feat: add diff commit session launcher (#585) fix: avoid error state for empty titled code reviews (#587) fix: cancel in-flight auto reviews before manual sessions (#584) feat(settings): add repo context search (#583) fix(staged): sort timeline items by completion time so queued items appear before completed ones (#568) fix: drain queued branch sessions from backend lifecycle (#579) fix: restore resume session metadata for resumed actions (#580) feat(staged): add purple diff comment theme (#578) fix(ui): hide branch actions during setup (#572) fix: validate parsed PR URLs before extraction (#577) fix: centralize staged relative time updates (#576) fix: avoid UI freezes when starting background sessions (#575) ... # Conflicts: # apps/penpal/internal/watcher/watcher.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completedAt(falling back tocreatedAt) instead ofcreatedAtfor ranking reviews and notes in the commit prefill timelineTest plan
completedAtis not set🤖 Generated with Claude Code