fix(mobile): retain live thread replies in channel window - #3344
Open
smltr wants to merge 3 commits into
Open
Conversation
Co-authored-by: Sam Trouy <smltr@proton.me> Signed-off-by: Sam Trouy <smltr@proton.me>
|
bumping this 👆🏾 |
Keep the live-reply regression tests away from main's newly added local-row summary test so both changes merge without conflict. Co-authored-by: Daniel Aguilera <daguiler@gmail.com> Signed-off-by: Daniel Aguilera <daguiler@gmail.com>
|
Current Verified on the follow-up head:
I also resolved the integration directly on current |
test(mobile): avoid block#3344 conflict with current main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mobile received ordinary live thread replies but discarded them at the channel-window storage boundary unless they carried
broadcast=1. Because the replies never reached the window store, the parent message could not update its thread summary until the app reloaded the channel from the relay.This change:
Related issue
Fixes #3293.
An issue/PR search found no duplicates
Testing
flutter test test/features/channels/channel_messages_provider_test.dart— 15 passedjust mobile-check— formatting, Flutter analysis, and mobile file-size checks passedflutter test— 826 passed, 1 skippedgit diff --check— passed2ce2d71cc: an incoming threaded reply did not update the parent summary until the app was restarted.0f7fec6ca: the parent gained the reply summary live without restart, and the reply remained out of the top-level timeline.No screenshots or recordings captured