Skip to content

fix(mobile): retain live thread replies in channel window #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smltr wants to merge 3 commits into
base: main
Choose a base branch
from
+74 −7
Open

fix(mobile): retain live thread replies in channel window #3344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f7fec6
fix(mobile): retain live thread replies in channel window
smltr Jul 28, 2026
a1b7c00
test(mobile): move live reply coverage past hydration
daguiler76 Jul 31, 2026
b3d2916
Merge pull request #1 from daguiler76/fix/pr-3344-conflict-layout
smltr Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions mobile/lib/features/channels/channel_messages_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ class ChannelMessagesNotifier extends Notifier<AsyncValue<List<NostrEvent>>> {
),
);
}
if (!_isBroadcastReply(event)) return false;
}
if (!isTimelineRow &&
!EventKind.channelAuxEventKinds.contains(event.kind)) {
Expand Down Expand Up @@ -461,12 +460,6 @@ class ChannelMessagesNotifier extends Notifier<AsyncValue<List<NostrEvent>>> {
}
}

bool _isBroadcastReply(NostrEvent event) {
return event.tags.any(
(tag) => tag.length >= 2 && tag[0] == 'broadcast' && tag[1] == '1',
);
}

int _currentUnixSeconds() => DateTime.now().millisecondsSinceEpoch ~/ 1000;

final channelMessagesProvider =
Expand Down
74 changes: 74 additions & 0 deletions mobile/test/features/channels/channel_messages_provider_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:buzz/features/channels/channel_messages_provider.dart';
import 'package:buzz/features/channels/pending_local_messages_provider.dart';
import 'package:buzz/features/channels/thread_replies_provider.dart';
import 'package:buzz/features/channels/timeline_message.dart';
import 'package:buzz/shared/relay/relay.dart';

void main() {
Expand Down Expand Up @@ -282,6 +283,79 @@ void main() {
);
});

test('live non-broadcast reply updates its parent thread summary', () async {
final relaySession = _RecordingRelaySessionNotifier(
queryResults: [
[_event(id: 'root', createdAt: 10), _bounds()],
],
);
final container = _buildContainer(relaySession);
addTearDown(container.dispose);

container.read(channelMessagesProvider(_channelId));
await relaySession.subscribed;
await _pumpEventQueue();

relaySession.emit(
_event(
id: 'reply',
createdAt: 20,
extraTags: const [
['e', 'root', '', 'reply'],
],
),
);
await _pumpEventQueue();

final notifier = container.read(
channelMessagesProvider(_channelId).notifier,
);
final events = container.read(channelMessagesProvider(_channelId)).value!;
final entries = buildMainTimelineEntries(
formatTimeline(events),
relaySummaries: notifier.threadSummaries,
);

expect(entries.single.summary?.replyCount, 1);
});

test(
'live non-broadcast reply stays out of the top-level timeline',
() async {
final relaySession = _RecordingRelaySessionNotifier(
queryResults: [
[_event(id: 'root', createdAt: 10), _bounds()],
],
);
final container = _buildContainer(relaySession);
addTearDown(container.dispose);

container.read(channelMessagesProvider(_channelId));
await relaySession.subscribed;
await _pumpEventQueue();

relaySession.emit(
_event(
id: 'reply',
createdAt: 20,
extraTags: const [
['e', 'root', '', 'reply'],
],
),
);
await _pumpEventQueue();

final events = container.read(channelMessagesProvider(_channelId)).value!;
expect(events.map((event) => event.id), ['root', 'reply']);
expect(
buildMainTimelineEntries(
formatTimeline(events),
).map((entry) => entry.message.id),
['root'],
);
},
);

test(
'thread replies are inserted, deduped, and rolled back locally',
() async {
Expand Down