fix(python): align SDK errors and metadata#954
Closed
G4614 wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
||
| # Try to import sync API - skip if greenlet not installed | ||
| try: | ||
| import boxlite |
This was referenced Jul 9, 2026
DorianZheng
pushed a commit
that referenced
this pull request
Jul 10, 2026
Add metrics() to async SimpleBox so it matches the synchronous convenience API. Test plan: - [x] cargo fmt --all - [x] sdks/python/.venv/bin/python -m py_compile sdks/python/boxlite/simplebox.py sdks/python/tests/test_simplebox.py - [x] BOXLITE_DEPS_STUB=1 cargo check -p boxlite-python - [ ] Not rerun on debug host after splitting; the same SimpleBox metrics path passed on debug host before the split in #954 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added an async `metrics()` capability to `SimpleBox` to retrieve resource usage (CPU/memory) for a box that has been started. * Enforces the same started/ready-state requirement as other `SimpleBox` actions. * **Tests** * Added an integration test that starts a `SimpleBox`, runs a command, retrieves `box.metrics()`, and verifies metrics are returned and include a non-zero `commands_executed_total`. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align BoxInfo defaults and Python convenience API errors with actual runtime behavior.
Test plan: