fix(python): clarify Boxlite context manager#961
Open
G4614 wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthrough
ChangesPython context management
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant PythonCaller
participant PyBoxlite
participant Runtime
PythonCaller->>PyBoxlite: async with runtime
PyBoxlite-->>PythonCaller: return runtime from __aenter__
PythonCaller->>PyBoxlite: exit async context
PyBoxlite->>Runtime: shutdown(None)
PyBoxlite-->>PythonCaller: return false
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
13 tasks
G4614
force-pushed
the
g4614/pol-102-boxlite-context-manager
branch
from
July 14, 2026 12:54
5061964 to
39cc257
Compare
G4614
marked this pull request as ready for review
July 20, 2026 11:35
📦 BoxLite review — couldn't completepowered by BoxLite |
G4614
enabled auto-merge
July 20, 2026 11:35
G4614
force-pushed
the
g4614/pol-102-boxlite-context-manager
branch
2 times, most recently
from
July 23, 2026 08:45
39cc257 to
0d21b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make native Boxlite support async context management and reject sync context-manager usage with a SyncBoxlite hint.
Test plan:
Summary by CodeRabbit
New Features
async with.Bug Fixes
withnow raises a clear error directing users to the correct synchronous API.Tests