chore: Simplify github workflows and allow for required jobs#1548
Merged
Luca Forstner (lforst) merged 5 commits intomainfrom Mar 13, 2026
Merged
chore: Simplify github workflows and allow for required jobs#1548Luca Forstner (lforst) merged 5 commits intomainfrom
Luca Forstner (lforst) merged 5 commits intomainfrom
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 12, 2026
Member
|
While you're here, you can swap out with:
node-version: 22To point to https://github.com/braintrustdata/braintrust-sdk-javascript/blob/main/.tool-versions instead via # https://github.com/actions/setup-node
# File containing the version Spec of the version to use. Examples: package.json, .nvmrc, .node-version, .tool-versions.
# If node-version and node-version-file are both provided the action will use version from node-version.
node-version-file: ''Otherwise I can do it in a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplifies worfkflows into:
Also adds a job to the checks workflow that allows us to make the runs required (in case we want to turn on auto-merge)