Skip to content

stop using mock blockchain - was causing data race #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freemans13 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

stop using mock blockchain - was causing data race #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/blockvalidation/BlockValidation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3079,6 +3079,7 @@ func TestBlockValidation_OptimisticMining_InValidBlock(t *testing.T) {
mockBlockchain.On("SetBlockSubtreesSet", mock.Anything, mock.Anything).Return(nil)
mockBlockchain.On("GetBestBlockHeader", mock.Anything).Return(&model.BlockHeader{}, &model.BlockHeaderMeta{Height: 100}, nil)

mockBlockchain.On("ReValidateBlock", mock.Anything, mock.Anything).Return()
Copy link
Contributor

@github-actions github-actions bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mock line is incorrect and unnecessary. ReValidateBlock is a method on BlockValidation itself (BlockValidation.go:1631), not on the blockchain client interface. The blockchain interface has RevalidateBlock (lowercase v) at Interface.go:508. Remove this line.

txMetaStore, subtreeValidationClient, _, txStore, subtreeStore, deferFunc := setup(t)
defer deferFunc()

Expand Down
Loading