Add googleapis/cloud-run requirements
#1100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
unmultimedio
changed the title
googleapis/cloud-run requirements
This was referenced Nov 25, 2025
mfridman
approved these changes
Nov 26, 2025
Member
mfridman
left a comment
mfridman
left a comment
There was a problem hiding this comment.
Hope googleapis doesn't create a reverse dependency 🤞 .
unmultimedio
commented
Nov 26, 2025
Member
Author
unmultimedio
left a comment
unmultimedio
left a comment
There was a problem hiding this comment.
Double checked imports, just to be safe.
| # Required for api/client.proto | ||
| + api/launch_stage.proto | ||
| # Required for googleapis/cloud-run | ||
| + api/routing.proto |
Member
Author
There was a problem hiding this comment.
It imports only WKT:
import "google/protobuf/descriptor.proto";| + geo/type/viewport.proto | ||
|
|
||
| # Required for googleapis/cloud-run | ||
| + iam/v1/iam_policy.proto |
Member
Author
There was a problem hiding this comment.
It imports files that are already here, and WKT:
import "google/api/annotations.proto";
import "google/api/client.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/iam/v1/options.proto";
import "google/iam/v1/policy.proto";
import "google/protobuf/field_mask.proto";|
|
||
| # Required for googleapis/cloud-run | ||
| + iam/v1/iam_policy.proto | ||
| + iam/v1/options.proto |
Member
Author
There was a problem hiding this comment.
Doesn't have any import.
| # Required for googleapis/cloud-run | ||
| + iam/v1/iam_policy.proto | ||
| + iam/v1/options.proto | ||
| + iam/v1/policy.proto |
Member
Author
There was a problem hiding this comment.
It imports only WKT:
import "google/type/expr.proto";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional files are imports for the requested
googleapis/cloud-runmodule: #1092We need to first sync these ones to at least one ref, before adding that new module.