Skip to content

Add googleapis/cloud-run requirements #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unmultimedio merged 1 commit into from
Nov 26, 2025
Merged

Add googleapis/cloud-run requirements #1100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/static/googleapis/googleapis/rsync.incl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
+ api/visibility.proto
# Required for api/client.proto
+ api/launch_stage.proto
# Required for googleapis/cloud-run
+ api/routing.proto
Copy link
Member Author

@unmultimedio unmultimedio Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It imports only WKT:

import "google/protobuf/descriptor.proto";


# api/expr/v1alpha1 is required for xds and envoy.
+ api/expr/v1alpha1/checked.proto
Expand All @@ -42,6 +44,11 @@
# All of geo
+ geo/type/viewport.proto

# Required for googleapis/cloud-run
+ iam/v1/iam_policy.proto
Copy link
Member Author

@unmultimedio unmultimedio Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It imports files that are already here, and WKT:

import "google/api/annotations.proto";
import "google/api/client.proto";
import "google/api/field_behavior.proto";
import "google/api/resource.proto";
import "google/iam/v1/options.proto";
import "google/iam/v1/policy.proto";
import "google/protobuf/field_mask.proto";

+ iam/v1/options.proto
Copy link
Member Author

@unmultimedio unmultimedio Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have any import.

+ iam/v1/policy.proto
Copy link
Member Author

@unmultimedio unmultimedio Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It imports only WKT:

import "google/type/expr.proto";


# All of rpc
+ rpc/code.proto
+ rpc/context/attribute_context.proto
Expand Down