Kinetic experimental#6
Kinetic experimental#6yann-bourrigault wants to merge 8 commits intobulwahn:kinetic-experimentalfrom
Conversation
Rosbridge python library needs the bson package to work, which is indeed an extract of the pymongo package. The python-bson package is a different one not containing the necessary dependencies, causing a runtime error.
Wxwidgets & wxpython 2.9.5 are not compatible with webkitgtk 2.8.5
Roslaunch needs paramiko to launch remote nodes
|
|
||
| DEPENDS = "rosconsole tf roscpp angles message-generation dynamic-reconfigure libtinyxml \ | ||
| realtime-tools message-filters" | ||
| realtime-tools message-filters control-msgs" |
There was a problem hiding this comment.
Commit is subsumed by other changes.
On kinetic-experimental-v3-alpha1, this issue is already addressed with commit b5f8edd ("control-toolbox: add control-msgs").
For the indigo release, the control_toolbox package does not need control_msgs [1]; commit b5f8edd is specific to kinetic and does not need be backported to master.
[1] https://github.com/ros-controls/control_toolbox/blob/indigo-devel/package.xml
bulwahn
left a comment
There was a problem hiding this comment.
Mostly subsumed by other changes.
| SRC_URI = "https://github.com/jbeder/yaml-cpp/archive/release-${PV}.tar.gz" | ||
| SRC_URI[md5sum] = "2728af8a15e2b2c407730c45b99b274b" | ||
| SRC_URI[sha256sum] = "6fb92f6f5925e0af918ffbb90acf19b7b88706ebcd40fc186b7caa76609b6350" | ||
| SRC_URI[md5sum] = "96bdfa47d38711737d973b23d384d4f2" |
There was a problem hiding this comment.
On indigo (bmwcarit/master) and kinetic-experimental-v3-alpha1, yaml-cpp is updated
to 0.5.3 and loaded with git. So, this issue of this hunk has been resolved in indigo (bmwcarit/master)
and kinetic-experimental-v3-alpha1.
|
|
||
| SRC_URI[md5sum] = "7335d233f7ad4ecc4b508aec7b5dc101" | ||
| SRC_URI[sha256sum] = "55708944872bab1015b8ae07b379bf463764f469163a8fd114cbb16c5e486ca8" | ||
| SRC_URI[md5sum] = "cb530d737c8f2d1023797cf0587b4e05" |
There was a problem hiding this comment.
I executed bitbake sphinxbase -c cleanall && bitbake sphinxbase -c fetch, it downloaded
the archive and I did not get any hash mismatch error reported. So, I cannot reproduce this
issue and we both, committer and reviewer, must recheck which is the right hash.
| SRC_URI = "https://github.com/ros-perception/${ROS_SPN}/archive/${PV}.tar.gz;downloadfilename=${ROS_SP}.tar.gz" | ||
| SRC_URI[md5sum] = "537c8dca08fe8a936438252b3ee6cdc8" | ||
| SRC_URI[sha256sum] = "2d9b10f1e3c22145d58ba922dcafc72b149bb4561e641fff17eddf1510294271" | ||
| SRC_URI[md5sum] = "855253ebefbcf508d2af7dd3e8d5d15a" |
There was a problem hiding this comment.
On kinetic-experimental-v3-alpha1, image-transport-plugins have already been
updated to version 1.9.5. So, this hunk does not apply to kinetic-experimental-v3-alpha1
anymore.
There was a problem hiding this comment.
Commit d912686 ("Log4cxx repository is not reachable without https") is subsumed by other changes.
On indigo (bmwcarit/master) and kinetic-experimental-v3-alpha1, this was
already changed to download from the git repository using https. So, this patch does not apply to the indigo (master) and kinetic-experimental-v3-alpha1.
There was a problem hiding this comment.
commit 6ea4890 ("Fix absolute tcl include path in python imaging compilation") is subsumed by other changes.
There is no python-imaging recipe in indigo (bmwcarit/master) and kinetic-experimental-v3-alpha1. I removed this recipe from meta-ros in ros#421.
It is now maintained in meta-python:
http://cgit.openembedded.org/meta-openembedded/tree/meta-python/recipes-devtools/python/python-imaging_1.1.7.bb?h=master
| @@ -1,12 +0,0 @@ | |||
| DESCRIPTION = "Independent BSON codec for Python that doesn't depend on MongoDB" | |||
There was a problem hiding this comment.
Commit is subsumed by other changes.
This is a valuable commit; this issue is however already addressed in
bmwcarit#509.
| LIC_FILES_CHKSUM = "file://package.xml;beginline=10;endline=10;md5=68b329da9893e34099c7d8ad5cb9c940" | ||
|
|
||
| DEPENDS = "message-generation std-msgs geometry-msgs rospy python-six python-bson python-pytz" | ||
| DEPENDS = "message-generation std-msgs geometry-msgs rospy python-six python-pymongo python-pytz python-html python-imaging python-twisted" |
There was a problem hiding this comment.
Commit is subsumed by other changes.
This is a valuable commit; this issue is however already addressed in
bmwcarit#509.
| @@ -0,0 +1,13 @@ | |||
| DESCRIPTION = "Python driver for MongoDB" | |||
There was a problem hiding this comment.
Commit is subsumed by other changes.
This is a valuable commit; this issue is however already addressed in
bmwcarit#509.
|
Here some further general remark: You might want to update to kinetic-experimental-v3-alpha1, which is currently the latest kinetic branch. |
|
Commit 4746242 ("Upgrade wxwidgets & wxpython to 3.0 version") is a valuable commit. I build upon your commit some further changes. These changes are currently for review at this pull request: |
|
Commit cae316e ("Support remote node execution") is a valuable commit. I build upon your commit some further changes. These changes are currently for review at this pull request ros#572. [1] https://github.com/ros/ros_comm/blob/kinetic-devel/tools/roslaunch/package.xml |
This pull request contains various fixes to obtain a fully working ROS Kinetic setup.
Noticeable changes:
All new recipes versions are based on Ubuntu 16.04 current versions.