improve roslaunch and support remote node execution#572
Conversation
|
I tested the following builds:
|
| @@ -0,0 +1,22 @@ | |||
| Index: pycrypto-2.6/setup.py | |||
There was a problem hiding this comment.
Should we put Upstream-Status into this patch?
There was a problem hiding this comment.
I was thinking about this as well; but then deferred the activity for a next pull request because I would need to understand the whole rationale of the patch, re-build without the patch, see the error message, understand the patch and look if it has been contributed somewhere. Nevertheless, it should be added and should be really added to meta-openembedded and meta-ros. I just did not do it here for this pull request yet.
| export STAGING_INCDIR | ||
| export STAGING_LIBDIR | ||
| export BUILD_SYS | ||
| export HOST_SYS |
There was a problem hiding this comment.
Are these exports really needed? I've just tried to build without them and everything seems to build ok. Probably a comment would be useful why they are here.
…ipe (#12) python-defusedxml: update to version 0.5.0, use pypi, add python3 recipe
Roslaunch needs paramiko to launch remote nodes [backport to master from cae316e] [manually resolved conflict in roslaunch] Signed-off-by: Lukas Bulwahn <[email protected]>
|
I rebased this pull request from January: I could address @rojkov's comments by dropping the python-pycrypto recipe that is now with python3 support in meta-python.
with |
|
CI is green; so, I will merge this pull request now. |
These pull request provides a commit from the pull request bulwahn#6 and some important commits from the kinetic branch.