Skip to content

improve roslaunch and support remote node execution#572

Merged
bulwahn merged 9 commits intoros:masterfrom
bulwahn:python-paramiko
Jul 12, 2018
Merged

improve roslaunch and support remote node execution#572
bulwahn merged 9 commits intoros:masterfrom
bulwahn:python-paramiko

Conversation

@bulwahn
Copy link
Contributor

@bulwahn bulwahn commented Jan 2, 2018

These pull request provides a commit from the pull request bulwahn#6 and some important commits from the kinetic branch.

@bulwahn
Copy link
Contributor Author

bulwahn commented Jan 2, 2018

I tested the following builds:

  • Without ROS_USE_PYTHON3="yes", bitbake core-image-ros-world builds successful.
  • With ROS_USE_PYTHON3="yes", bitbake roslaunch builds successful, but bitbake core-image-ros-world fails with build errors described in Some ROS packages fail on ROS_USE_PYTHON3 = "yes" #570, which already occurred before this pull request.

@@ -0,0 +1,22 @@
Index: pycrypto-2.6/setup.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put Upstream-Status into this patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this as well; but then deferred the activity for a next pull request because I would need to understand the whole rationale of the patch, re-build without the patch, see the error message, understand the patch and look if it has been contributed somewhere. Nevertheless, it should be added and should be really added to meta-openembedded and meta-ros. I just did not do it here for this pull request yet.

export STAGING_INCDIR
export STAGING_LIBDIR
export BUILD_SYS
export HOST_SYS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these exports really needed? I've just tried to build without them and everything seems to build ok. Probably a comment would be useful why they are here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check this.

@bulwahn
Copy link
Contributor Author

bulwahn commented Jul 12, 2018

I rebased this pull request from January: I could address @rojkov's comments by dropping the python-pycrypto recipe that is now with python3 support in meta-python.

bitbake core-image-ros-world built succesfully on this build configuration:

Build Configuration:
BB_VERSION           = "1.37.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "ubuntu-16.04"
TARGET_SYS           = "i586-oe-linux"
MACHINE              = "qemux86"
DISTRO               = "nodistro"
DISTRO_VERSION       = "nodistro.0"
TUNE_FEATURES        = "m32 i586"
TARGET_FPU           = ""
meta                 = "master:f9324af88a99eca28b160fa31aa4516fd397e44b"
meta-oe              
meta-python          
meta-multimedia      = "master:b56fc26fefff498b10236ea6486a5d5624f726cc"
meta-ros             = "bulwahn-python-paramiko:27e95fdd3535cc8917e139d554ab79908fc69947"

with ROS_USE_PYTHON3 = "no".

@bulwahn
Copy link
Contributor Author

bulwahn commented Jul 12, 2018

CI is green; so, I will merge this pull request now.

@bulwahn bulwahn merged commit 12b4c59 into ros:master Jul 12, 2018
@bulwahn bulwahn deleted the python-paramiko branch July 12, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants