Skip to content

Conversation

@tillkruss
Copy link
Member

@tillkruss tillkruss commented Nov 28, 2025

Followup to #25.

  • Added trixie and plucky packages
  • Use relay-pkg.so for el7-9 packages
  • Build individual packages for debian
  • Use relay.so from 24.04 onwards

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores package building for multiple Linux distributions with important structural changes to the packaging system. It adds support for Debian 13 (trixie), configures EL7-9 packages to use relay-pkg.so binaries, and refactors the package generation to build distribution-specific packages for Debian-based systems.

Key changes:

  • Refactored fpm.sh from hardcoded package arrays to dynamic generation using loops over distributions, architectures, and PHP versions
  • Added trixie (Debian 13) to supported distributions
  • Introduced conditional binary selection (relay.so vs relay-pkg.so) based on distribution

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
build/fpm/fpm.sh Refactored from hardcoded array to dynamic package generation with loops; added trixie support
build/fpm/helpers.sh Added distro parameter and cleaned up download caching; removed pkg_mod parameter
build/fpm/src/rpm/config.*.el[7-9].sh Added pkg_binary configuration and commented out hiredis/ck dependencies for EL7-9 packages
build/fpm/src/deb/config.multi.sh Added distro-specific identifier and binary selection logic; conditional dependencies based on binary type
build/fpm/src/deb/config.ls.sh Added distro-specific identifier and binary selection logic; conditional dependencies based on binary type
build/fpm/src/deb/config.base.sh Added distro-specific identifier and binary selection logic; conditional dependencies based on binary type
build/deb-repo.sh Changed to array-based dists with trixie support; updated symlink logic to use distro-specific naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Nov 30, 2025

@tillkruss I've opened a new pull request, #28, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 30, 2025

@tillkruss I've opened a new pull request, #29, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 30, 2025

@tillkruss I've opened a new pull request, #30, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 30, 2025

@tillkruss I've opened a new pull request, #31, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Member Author

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot only define the Debian/Ubuntu list distros once. Avoid the duplicated list.

Copy link

Copilot AI commented Nov 30, 2025

@tillkruss I've opened a new pull request, #32, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Member

@michael-grunder michael-grunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't know a ton about packaging.

Nice improvement using a loop for the PHP versions though

@tillkruss tillkruss merged commit 283b9f0 into main Nov 30, 2025
@tillkruss tillkruss deleted the fix/restore-pkg branch November 30, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants