Skip to content

Conversation

Copy link

Copilot AI commented Nov 30, 2025

Fixes the RPM package URL construction to use correct distro names in the download URLs.

Changes Made

Added url_distro variable mapping to correctly generate RPM package URLs for Enterprise Linux distributions:

  • el7 → URLs use centos7 (e.g., $baseurl-php8.4-centos7-x86-64.tar.gz)
  • el8 → URLs use centos8 (e.g., $baseurl-php8.4-centos8-x86-64.tar.gz)
  • el9 → URLs use el9 (unchanged)
for el in el7 el8 el9; do
  url_distro=$(echo $el | sed 's/el7/centos7/; s/el8/centos8/')

  packages+=(
    "$el rpm single.$el $arch $php $api $baseurl-php$php-$url_distro-${arch/_/-}.tar.gz"
    "$el rpm multi.$el  $arch $php $api $baseurl-php$php-$url_distro-${arch/_/-}.tar.gz"
    "$el rpm ls.$el     $arch $php $api $baseurl-php$php-$url_distro-${arch/_/-}.tar.gz"
  )
done

This addresses the feedback about incorrect URL patterns that would use -el7-, -el8- instead of the expected -centos7-, -centos8- patterns.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Nov 30, 2025
Copilot AI changed the title [WIP] Update pkg restoration in distros based on feedback Verify variant suffix fixes for libssl3 distributions Nov 30, 2025
Copilot AI requested a review from tillkruss November 30, 2025 00:11
Copy link
Member

@tillkruss tillkruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing was changed. Restart your work.

Copy link
Author

Copilot AI commented Nov 30, 2025

Nothing was changed. Restart your work.

Fixed in ea66cf9. Added the url_distro variable mapping to correctly generate RPM package URLs:

  • el7 → centos7
  • el8 → centos8
  • el9 → el9 (unchanged)

Copilot AI changed the title Verify variant suffix fixes for libssl3 distributions Fix RPM URL distro names for EL packages Nov 30, 2025
Copilot AI requested a review from tillkruss November 30, 2025 00:29
@tillkruss tillkruss closed this Nov 30, 2025
@tillkruss tillkruss deleted the copilot/sub-pr-27-again branch November 30, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants