test: increase code coverage for data/apport #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 83.92% 83.93%
=======================================
Files 101 101
Lines 20455 20461 +6
Branches 3215 3217 +2
=======================================
+ Hits 17167 17173 +6
- Misses 2839 2840 +1
+ Partials 449 448 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
force-pushed
the
increase-coverage
branch
from
593746e to
c6659e8
Compare
Calling `data/apport` via `subprocess.check_call` will not be covered by coverage. Call into the `data/apport` code directly to get it covered. pytest will fail with PermissionError and INTERNALERROR on cleanup when running all integration tests as root. So keep using `subprocess.check_call` for tests that set a different UID.
bdrung
force-pushed
the
increase-coverage
branch
from
c6659e8 to
e195ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
data/apportviasubprocess.check_callwill not be covered by coverage. Call into thedata/apportcode directly to get it covered.pytest will fail with PermissionError and INTERNALERROR on cleanup when running all integration tests as root. So keep using
subprocess.check_callfor tests that set a different UID.