refactor: Improve testing and docs#375
Merged
MichaelThamm merged 2 commits intocanonical:mainfrom Mar 24, 2026
Merged
Conversation
385b4a4 to
0ab9393
Compare
MichaelThamm
commented
Mar 23, 2026
sinapah
reviewed
Mar 24, 2026
sinapah
reviewed
Mar 24, 2026
sinapah
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Why is this needed?
This PR simplifies the OTLP testing by removing the
otlp_dual_ctxcharm fixture for testing the requirer and provider charms in isolation. This is the intended way to test libraries with Scenario since we can provideremoteandlocaldatabags to provide sufficient coverage. The previous testing was leaking otelcol implementation detail into the library.Drive-by fixes
_OtlpAppDatamodels private since they are not public and to indicate that they are not intended to be.otlp_dual_ctxcharm fixture, tests for metadata and provider rules were added.juju_charminstead ofcharm.README,__init__, andconftest.For example, before:
now:
User-facing changes
This PR does not actually functionally change the lib and is simply cosmetic. However, the documentation was updated which is user-facing. I will release as part of: