feat: Replace the requirer's rule interface with a rules object#376
Merged
MichaelThamm merged 11 commits intocanonical:mainfrom Mar 25, 2026
Merged
feat: Replace the requirer's rule interface with a rules object#376MichaelThamm merged 11 commits intocanonical:mainfrom
MichaelThamm merged 11 commits intocanonical:mainfrom
Conversation
3 tasks
3974030 to
0ab9393
Compare
MichaelThamm
commented
Mar 23, 2026
MichaelThamm
commented
Mar 23, 2026
MichaelThamm
commented
Mar 23, 2026
MichaelThamm
commented
Mar 23, 2026
MichaelThamm
commented
Mar 23, 2026
sinapah
reviewed
Mar 24, 2026
sinapah
reviewed
Mar 24, 2026
sinapah
reviewed
Mar 24, 2026
MichaelThamm
commented
Mar 24, 2026
Co-authored-by: Sina P <55766091+sinapah@users.noreply.github.com>
MichaelThamm
commented
Mar 24, 2026
sinapah
reviewed
Mar 24, 2026
This was referenced Mar 24, 2026
Open
sinapah
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Blocked by these PRs:
Blocking this PR:
Why is this needed?
This PR allows users of the lib to build a rules object (built around the
cosl.rules.Rulesclass) and pass that to theOtlpRequirerfor publishing to the databag. The library adds its own rules to this object e.g., generic alert rules prior to publishing to the relation databag. TheRuleStoreis the API used to build the rules object which has a similar API to thecosl.rules.Rulesclass which uses theaddandadd_pathmethods to store rules.API
Old
New