fix: add proper type to hosts in haproxy libraries#383
Open
skatsaounis wants to merge 1 commit intocanonical:mainfrom
Open
fix: add proper type to hosts in haproxy libraries#383skatsaounis wants to merge 1 commit intocanonical:mainfrom
skatsaounis wants to merge 1 commit intocanonical:mainfrom
Conversation
89e657e to
abd5475
Compare
Contributor
Test results for commit abd5475Test coverage for abd5475 Static code analysis report |
Contributor
Test results for commit abd5475Test coverage for abd5475 Static code analysis report |
Contributor
Test results for commit abd5475Test coverage for abd5475 Static code analysis report |
Collaborator
There was a problem hiding this comment.
we would need to increment the lib's patch version number and publish a new version of the lib so that we can fetch it from requirer charms like ingress-configurator. Can I ask you to first increment the LIBPATCH number? I'll take care of publishing the library once that's done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
docs/release-notes/artifacts. If this PR does not require a change artifact, the PR has been tagged withno-release-note.urgent,trivial,complex)