Skip to content

fix: add proper type to hosts in haproxy libraries #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skatsaounis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add proper type to hosts in haproxy libraries #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion haproxy-operator/lib/charms/haproxy/v1/haproxy_route_tcp.py
View file
Open in desktop
Copy link
Collaborator

@Thanhphan1147 Thanhphan1147 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we would need to increment the lib's patch version number and publish a new version of the lib so that we can fetch it from requirer charms like ingress-configurator. Can I ask you to first increment the LIBPATCH number? I'll take care of publishing the library once that's done

Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ def configure_backend_port(self, backend_port: int) -> "Self":
self._application_data["backend_port"] = backend_port
return self

def configure_hosts(self, hosts: Optional[list[int]] = None) -> "Self":
def configure_hosts(self, hosts: Optional[list[str]] = None) -> "Self":
"""Set backend hosts.

Args:
Expand Down
Loading