docs: update tutorials and example charms to match Charmcraft 4.2#2407
docs: update tutorials and example charms to match Charmcraft 4.2#2407
Conversation
- Update base from ubuntu@22.04 to ubuntu@24.04 in all k8s and machine example charms - Add `assumes: juju >= 3.6` (+ `k8s-api` for k8s charms) to all example charmcraft.yaml files - Update juju >= 3.1 to juju >= 3.6 in httpbin-demo - Update pyproject.toml dependency comment to new template wording in all 7 examples - Fix extend-exclude position in httpbin-demo/pyproject.toml (move after lint.per-file-ignores) - Remove commented-out lib_path variable from tox.ini [vars] section in 6 examples - Remove commented-out codespell lib_path lines from tox.ini [testenv:lint] in 6 examples Agent-Logs-Url: https://github.com/canonical/operator/sessions/77fddcbd-6394-42d9-b280-d709c376e9e0 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>
dwilding
changed the title
|
@copilot there's more we need to do here. Look at the tinyproxy charm. It installs a specific version of tinyproxy, which will be different now that we've bumped the Ubuntu base. Please figure out everything that needs changing in the charm and also in the machine charm tutorial. After you have finished, I'll run the charm's integration tests locally to verify. |
…e) for Ubuntu 24.04 Agent-Logs-Url: https://github.com/canonical/operator/sessions/ba206838-a728-4d9a-ad84-e5c049d6779d Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>
Done in e50201a. The changes:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot please review both tutorial source carefully. Is there anywhere else that the Ubuntu base is shown in status output, filenames, etc? (There might not be). If yes, please update. |
Checked both tutorial sources — no remaining |
| # 'charm-libs' block in charmcraft.yaml, run `charmcraft fetch-libs` to download the libraries, | ||
| # then inspect the libraries for dependencies specified in PYDEPS. List those dependencies here. | ||
| dependencies = [ | ||
| "ops>=2.23,<4", # Version 2.23 introduced the load_config() method. |
There was a problem hiding this comment.
I seem to remember we decided to keep one example charm on Ops 2.
|
Not at all urgent for review (can happily wait until next week). I've left my discussion comments with Copilot open in case they're interesting to read. |
This PR updates our example charms to match the latest Charmcraft profiles. For details of what changed in the profiles, see canonical/charmcraft-profile-tools#15.
The most significant change is bumping the base from 22.04 to 24.04. This affects the workload version of the tinyproxy charm. So I'm bumping the installed version in the charm and its integration tests - which also affects the machine charm tutorial (preview). I ran the integration tests locally to validate the changes.