expand clang-tidy checks to category/rpc #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkolosick
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR improves const-correctness across the codebase by refactoring the mutation analyzer, adding const qualifiers to variables and parameters, adding explicit constructors, and including the category/rpc directory in clang-tidy checks.
- Refactored
ExprAutoMutationAnalyzer::isUnevaluatedto be a simpler static method with clearer API - Added
constqualifiers to many local variables, parameters, and return values throughout the codebase - Added
explicitkeyword to single-parameter constructors to prevent implicit conversions - Fixed forwarding references to use
std::forwardinstead ofstd::move
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/clang-tidy-auto-const/ExprAutoMutationAnalyzer.hpp | Simplified isUnevaluated method signature and moved it to public static |
| utils/clang-tidy-auto-const/ExprAutoMutationAnalyzer.cpp | Refactored isUnevaluated implementation with updated matcher logic |
| scripts/check-clang-tidy.sh | Added category/rpc to directories checked by clang-tidy |
| category/rpc/monad_executor_test.cpp | Added const qualifiers to test variables and fixed pointer declarations |
| category/rpc/monad_executor.cpp | Improved const-correctness and removed unnecessary std::move on const variables |
| category/mpt/*.hpp | Added explicit constructors, NOLINT suppressions, and improved const-correctness |
| category/execution/ethereum/state3/account_state.hpp | Updated move semantics for account initialization |
| category/execution/ethereum/rlp/*.hpp | Improved type safety in arithmetic operations and const-correctness |
| category/execution/ethereum/db/*.hpp | Added explicit constructors for database classes |
| category/execution/ethereum/trace/prestate_tracer.hpp | Added explicit constructors for tracer classes |
| category/core/lru/lru_cache.hpp | Made RAII lock holders const and improved constructors |
| category/core/mem/batch_mem_pool.hpp | Added explicit constructor |
| category/core/hash.hpp | Added NOLINT for sizeof expression in hash function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkolosick
force-pushed
the
mkolosick/clang-tidy-rpc
branch
2 times, most recently
from
5212e50 to
446c732
Compare
jhunsaker
force-pushed
the
mkolosick/clang-tidy-rpc
branch
from
446c732 to
dedf373
Compare
mkolosick
force-pushed
the
mkolosick/clang-tidy-rpc
branch
3 times, most recently
from
da67e9c to
1ef5b00
Compare
jhunsaker
approved these changes
Nov 7, 2025
- disable performance-move-const-arg.CheckTriviallyCopyableMove as it provides no performance improvement and makes the code unstable for future changes.
jhunsaker
force-pushed
the
mkolosick/clang-tidy-rpc
branch
from
1ef5b00 to
a13ede5
Compare
zander-xyz
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required backporting a fix for a clang-tidy bug from upstream llvm.