fix(choreops): use configured points label in notifications#157
Merged
Conversation
What changed: - Found that custom_from_complete could reschedule a chore back into the past after a missed-and-locked reset. - Included chore_name in the CHORE_MISSED payload so missed notifications no longer fall back to Unknown Chore. Why: - Prevent repeated expired/missed notifications Fixes #132
What changed:
- Add shared notification placeholder defaults for the configured points label.
- Update the English notification templates to use {points_label} instead of hardcoded "points".
Why:
- Keeps notification wording aligned with the system’s configured points label.
- Avoids hardcoded currency text in user-facing notifications.
ccpk1
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhanced support for customizable points labeling in notifications, ensuring that all user-facing messages dynamically use the configured label for points (e.g., "stars", "credits", etc.) instead of the hardcoded "points". It also includes a minor fix to chore missed event signaling and a small scheduling improvement.
Customizable Points Label in Notifications:
_get_points_labelmethod and a_build_notification_placeholdershelper inNotificationManagerto inject the configured points label into all notification messages. All notification formatting now uses these placeholders to ensure the correct label is shown. [1] [2] [3] [4]en_notifications.jsonso all relevant notification messages use{points_label}instead of hardcoded "points", making messages dynamically reflect the configured label. [1] [2] [3] [4]