Fix matching routes with trailing slash (refs #532)

[Sija]

Hi,

It's an attempt to fix non-functioning routes when using trailing slash. I stumbled upon it while testing my app with urls like http://app-domain.dev/recipes vs http://app-domain.dev/recipes/, where in the latter case Chaplin doesn't recognise my routes anymore.

My routes.js.coffee:

define ->
  'use strict'

  (match) ->

    # ... snip ...

    match 'recipes',          'recipes#index', name: 'recipes'
    match 'recipes/new',      'recipes#new',   name: 'new_recipe'
    match 'recipes/:id',      'recipes#show',  name: 'recipe'
    match 'recipes/:id/edit', 'recipes#edit',  name: 'edit_recipe'

    # ... snip ...

[akre54]

Relevant backbone discussion: jashkenas/backbone#848

[paulmillr]

I think we should instead redirect users from trailing-slash-URLs to non-trailing-slash-URLs (can be disabled in config).

What do you think?

users/paulmillr/ => users/paulmillr

No mess with SEO.

[Sija]

👍

[paulmillr]

Can you also please handle null case with true / false? On null it should behave as it currently behaves in 0.12

[akre54]

How about if @options.trailing isnt false? A switch on a boolean seems a bit weird.

[Sija]

well, going further if @options.trailing is true is even simpler ;)

[akre54]

But we want null/undefined to set trailing to true also. The only time we don't want it true is when trailing is false, hence trailing isnt false :)

[Sija]

In the referenced issue #532 setting values other than true or false would perform no redirecting whatsoever. That would be also my semantic understanding (yes–add a slash, no—remove it, null/undefined—abstain from action).

[Sija]

@paulmillr You mean in the tests? Right now there's a default setting trailing: no which makes Chaplin behave in a new but BC-compatible way.

[paulmillr]

I'll check it!

[paulmillr]

Awesome. Can you please squash all commits to one and i'll merge this?

[Sija]

Voila! :)

[paulmillr]

Thanks dude — this is awesome