Update quickstart-chat client module bindings from server#2976
Merged
Conversation
2 tasks
|
|
Collaborator
|
@alex47 Can you merge in |
bfops
approved these changes
Jul 24, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
This LGTM once master is merged in and those tests pass! Thank you!
Merged
via the queue into
clockworklabs:master
with commit Jul 25, 2025
ce90583
17 of 18 checks passed
Shubham8287
pushed a commit
that referenced
this pull request
Jul 28, 2025
Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io> Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
added a commit
that referenced
this pull request
Aug 7, 2025
Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io> Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
1 task
mamcx
pushed a commit
that referenced
this pull request
Aug 26, 2025
Co-authored-by: rekhoff <r.ekhoff@clockworklabs.io> Co-authored-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The example quickstart-chat client can not communicate with the example server, because the reducer names have been updated in the server, but not in the module bindings of the client.
I have run the following command in
\sdks\csharp\examples~\quickstart-chat\:spacetime generate --lang csharp --out-dir .\client\module_bindings\ --project-path serverAPI and ABI breaking changes
No changes.
Expected complexity level and risk
1
Testing