Add logging of service metadata during instance create/update/delete #4386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in service instance creation/update/deletion
kathap
force-pushed
the
log-more-service-details-on-creation
branch
from
7a5a766 to
cd65bf7
Compare
kathap
force-pushed
the
log-more-service-details-on-creation
branch
from
3a16543 to
e7b6273
Compare
kathap
force-pushed
the
log-more-service-details-on-creation
branch
from
72e4b4b to
1ebd8ae
Compare
svkrieger
force-pushed
the
log-more-service-details-on-creation
branch
from
6a3b167 to
511e64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform operators which service plan, service offering and broker is involved in service instance creation/update/deletion
A short explanation of the proposed change:
Add names of service plan, service offering and broker as logging information for service instance creation/update/deletion.
This change updates fetch_writable_service_instance to eagerly load associated service_plan, service, and service_broker relationships for managed service instances. This avoids N+1 queries when accessing these associations later in the request lifecycle.
An explanation of the use cases your change solves
This change improves operator visibility by logging service plan names, offerings, and broker names during service instance creation, update, and deletion.
Previously, logs only included GUIDs or IDs, requiring manual lookups or customer input to identify the service involved. With this change, operators can directly see which service is affected, making it easier to diagnose issues and support users/customers more efficiently.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests