-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport for Totem T2, to be used in the special run at 25.6, consisting of #41472 , #41777 and #41859 #41916
Backport for Totem T2, to be used in the special run at 25.6, consisting of #41472 , #41777 and #41859 #41916
Conversation
A new Pull Request was created by @oljemark for CMSSW_13_0_X. It involves the following packages:
@micsucmed, @nothingface0, @emanueleusai, @clacaputo, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ctpps |
please test |
To be decided. We either
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54d15c/33078/summary.html Comparison SummarySummary:
|
+reconstruction |
This PR will need a "backport" to https://github.com/cms-sw/cmssw/tree/CMSSW_13_0_7_TOTEM_X before we create the release. |
@tvami , there are few changes already merged for 13_0_X on top of 13_0_7 (CMSSW_13_0_7...CMSSW_13_0_X ). Looks like TOTEM release will not include those changes so better to test it for 13_0_7 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54d15c/33100/summary.html Comparison SummarySummary:
|
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_7_TOTEM_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@oljemark |
@syuvivida I might have missed where the playback request was done. Please remember to keep ORM in the loop when discussing the preparations for the totem run. |
Hi @syuvivida . The recent replay test on the 13_0_7_TOTEM release used run 368805, where TOTEM T2 & TrackingStrips were connected. Also, was this test done with the PPS DQM client in normal mode? The TrackingStrips & TotemT2 are only run in the calibration mode, set here https://github.com/CTPPS/cmssw/blob/0a38b0798473b67bf0e3e09296a128103c9ba8c7/DQM/Integration/python/clients/ctpps_dqm_sourceclient-live_cfg.py#L94 |
@syuvivida : we cannot judge the output in view of the Totem run as the run you have selected does not have T2 data neither strips data. So i suggest you use the same used for the T0 reply otherwise the test is not conclusive |
let me repeat myself, this sort of things need to coordinated at the joint ops level... |
@mmusich sorry I forgot to reply to you earlier. We are discussing about the playback runs in the online DQM machines. In the past, this piece of information was usually passed from the other DQM convener @emanueleusai to the DQM core team (after either reading the code or communication with the authors). |
@syuvivida I let you (as DQM expert) to clear up the internal details of the online DQM. What I mean is that for information such as which run to test, which Global Tags to use, etc., the ORM chat is the best place to ask, to avoid picking up configurations at random. |
@oljemark @vavati we just received streamers of 368805 at our playback machines this morning. The calibration sequence was turned on in this playback run. |
@syuvivida Thanks. I checked and the plots looks ok (at least they are not empty!) If you didn't get any issue during the playback I would say that these are validated. Next step will be another global run in a couple of days when T2 will be installed. |
PR description:
For the TOTEM special foreseen on 25.6.2023, the new T2 telescope will be used (and removed after the run) to measure inelastic rate and veto diffractive p+p collisions, when measuring the elastic p+p cross section.
This is a backport of three PR's: PR #41472 introduced 2-channel unpacking for T2, PR #41777 included T2 DQM plots additions and fixes, and PR #41859 added the T2 to the online DQM calibration path, but was descoped from including T2 RecHit reconstruction and use in DQM since some relVals were failing with "Deleting previous geometry: cmsMagneticField:MAGF/Detector" at the step where the T2 XML geometry was read in; this is possibly similar to issue #33203 (see discussion here: #41859 (comment) ).
After the descoping, T2 Digis are successfully saved in the event and used to produce Digi-based DQM plots in common reconstruction with the rest of the PPS detectors. An additional fourth PR with final DQM plot updates is being prepared for submission to master this weekend, that will also be backported to 13_0_X.
This backport is for a special TOTEM release to be ready for testing start of next week (#41859 (comment)).
PR validation:
T2 & PPS unit tests were run successfully, as were several PPS workflows and a few relVals that had failed with the geometry error noted above, before descoping of PR #41859 .
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a backport to 13_0_X for a special TOTEM release, consisting of three recent Totem T2 PRs: #41472 , #41777 & #41859 .