마이페이지 1:1 문의 카카오 채널 연결#697
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough모바일과 데스크톱 사이드바 네비게이션에서 "1:1 문의" 항목의 URL을 내부 라우트( Changes1:1 문의 외부 리다이렉트
🎯 2 (Simple) | ⏱️ ~12분
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/common/layout/sidebar/my-page-mobile-nav.tsx`:
- Line 11: Update the external link for the "1:1 문의" navigation item to use
HTTPS instead of HTTP: locate the nav item whose href is
'http://pf.kakao.com/_VmCYn' (identified by label '1:1 문의') and change the href
to 'https://pf.kakao.com/_VmCYn' so the link is secured; ensure any tests or
usages that reference this href are updated accordingly.
In `@src/components/common/layout/sidebar/my-page-sidebar.tsx`:
- Line 106: The desktop sidebar in MyPageSidebar contains an external link using
"http://pf.kakao.com/_VmCYn"; update that href to use HTTPS
(https://pf.kakao.com/_VmCYn) so it matches the mobile link and is secure, and
scan the MyPageSidebar component for any other occurrences of the same http URL
to replace them as well.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 68fc0588-09fa-44c7-b1d9-3f36d8bdc2dc
📒 Files selected for processing (2)
src/components/common/layout/sidebar/my-page-mobile-nav.tsxsrc/components/common/layout/sidebar/my-page-sidebar.tsx
| { href: '/my-class', label: '마이 클래스' }, | ||
| { href: '/my-posts', label: '내가 작성한 글', prefixMatch: true }, | ||
| { href: '/my-inquiry', label: '1:1 문의', prefixMatch: true }, | ||
| { href: 'http://pf.kakao.com/_VmCYn', label: '1:1 문의' }, |
There was a problem hiding this comment.
외부 링크는 HTTPS로 고정해 주세요.
현재 1:1 문의 링크가 http://라서 불필요한 보안 리스크가 생깁니다. https://로 변경하는 게 안전합니다.
수정 제안
- { href: 'http://pf.kakao.com/_VmCYn', label: '1:1 문의' },
+ { href: 'https://pf.kakao.com/_VmCYn', label: '1:1 문의' },📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { href: 'http://pf.kakao.com/_VmCYn', label: '1:1 문의' }, | |
| { href: 'https://pf.kakao.com/_VmCYn', label: '1:1 문의' }, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/common/layout/sidebar/my-page-mobile-nav.tsx` at line 11,
Update the external link for the "1:1 문의" navigation item to use HTTPS instead
of HTTP: locate the nav item whose href is 'http://pf.kakao.com/_VmCYn'
(identified by label '1:1 문의') and change the href to
'https://pf.kakao.com/_VmCYn' so the link is secured; ensure any tests or usages
that reference this href are updated accordingly.
| }, | ||
| { | ||
| href: '/my-inquiry', | ||
| href: 'http://pf.kakao.com/_VmCYn', |
There was a problem hiding this comment.
데스크톱 사이드바 링크도 HTTPS로 맞춰 주세요.
모바일과 동일하게 여기서도 http://가 사용되고 있어요. 외부 상담 링크는 https://로 통일하는 게 맞습니다.
수정 제안
- href: 'http://pf.kakao.com/_VmCYn',
+ href: 'https://pf.kakao.com/_VmCYn',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| href: 'http://pf.kakao.com/_VmCYn', | |
| href: 'https://pf.kakao.com/_VmCYn', |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/components/common/layout/sidebar/my-page-sidebar.tsx` at line 106, The
desktop sidebar in MyPageSidebar contains an external link using
"http://pf.kakao.com/_VmCYn"; update that href to use HTTPS
(https://pf.kakao.com/_VmCYn) so it matches the mobile link and is secure, and
scan the MyPageSidebar component for any other occurrences of the same http URL
to replace them as well.
There was a problem hiding this comment.
카카오톡 링크는 http://pf.kakao.com/_VmCYn가 맞습니다
1 participant
Problem
마이페이지 사이드바/모바일 네비게이션의 '1:1 문의' 항목 클릭 시 카카오 채널로 이동해야 하나, 외부 URL 처리 로직이 없어 내부 라우팅으로 처리되어 404가 발생하거나 아무 동작도 하지 않는 문제가 있었습니다.
Solution
href가http로 시작하는 항목은window.open(..., '_blank', 'noopener,noreferrer')로 새 탭 열기 처리. 데스크톱 사이드바(my-page-sidebar.tsx)와 모바일 네비게이션(my-page-mobile-nav.tsx) 모두 동일하게 적용했습니다.Changes
Bug Fixes
src/components/common/layout/sidebar/my-page-sidebar.tsxsrc/components/common/layout/sidebar/my-page-mobile-nav.tsxResult
'1:1 문의' 클릭 시 카카오 채널(
pf.kakao.com/_VmCYn)이 새 탭으로 열립니다. 기존 내부 네비게이션 동작에는 영향 없습니다.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
변경 사항