Skip to content

마이페이지 1:1 문의 카카오 채널 연결 #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HA-SEUNG-JEONG merged 2 commits into from
May 25, 2026
Merged

마이페이지 1:1 문의 카카오 채널 연결 #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57818c2
[myPage-v2] feat : 마이페이지 1:1 문의 클릭 시 카카오 채널로 연결
HA-SEUNG-JEONG May 25, 2026
8a9fdd0
[myPage-v2] fix : yarn.lock 업데이트
HA-SEUNG-JEONG May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/common/layout/sidebar/my-page-mobile-nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const NAV_ITEMS = [
{ href: '/my-page', label: '프로필' },
{ href: '/my-class', label: '마이 클래스' },
{ href: '/my-posts', label: '내가 작성한 글', prefixMatch: true },
{ href: '/my-inquiry', label: '1:1 문의', prefixMatch: true },
{ href: 'http://pf.kakao.com/_VmCYn', label: '1:1 문의' },
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

외부 링크는 HTTPS로 고정해 주세요.

현재 1:1 문의 링크가 http://라서 불필요한 보안 리스크가 생깁니다. https://로 변경하는 게 안전합니다.

수정 제안 
-  { href: 'http://pf.kakao.com/_VmCYn', label: '1:1 문의' },
+  { href: 'https://pf.kakao.com/_VmCYn', label: '1:1 문의' },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{ href: 'http://pf.kakao.com/_VmCYn', label: '1:1 문의' },
{ href: 'https://pf.kakao.com/_VmCYn', label: '1:1 문의' },
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/common/layout/sidebar/my-page-mobile-nav.tsx` at line 11,
Update the external link for the "1:1 문의" navigation item to use HTTPS instead
of HTTP: locate the nav item whose href is 'http://pf.kakao.com/_VmCYn'
(identified by label '1:1 문의') and change the href to
'https://pf.kakao.com/_VmCYn' so the link is secured; ensure any tests or usages
that reference this href are updated accordingly.

{ href: '/builder-letter', label: '빌더 레터', prefixMatch: true },
{ href: '/class-payment-management', label: '결제 관리' },
];
Expand All @@ -22,7 +22,13 @@ export default function MyPageMobileNav() {
{NAV_ITEMS.map((item) => (
<button
key={item.href}
onClick={() => router.push(item.href)}
onClick={() => {
if (item.href.startsWith('http')) {
window.open(item.href, '_blank', 'noopener,noreferrer');
return;
}
router.push(item.href);
}}
className={cn(
'font-designer-14m shrink-0 px-300 py-200 text-text-subtle',
(item.prefixMatch
Expand Down
7 changes: 5 additions & 2 deletions src/components/common/layout/sidebar/my-page-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,9 @@ const NAV_ITEMS: {
prefixMatch: true,
},
{
href: '/my-inquiry',
href: 'http://pf.kakao.com/_VmCYn',
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

데스크톱 사이드바 링크도 HTTPS로 맞춰 주세요.

모바일과 동일하게 여기서도 http://가 사용되고 있어요. 외부 상담 링크는 https://로 통일하는 게 맞습니다.

수정 제안 
-    href: 'http://pf.kakao.com/_VmCYn',
+    href: 'https://pf.kakao.com/_VmCYn',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
href: 'http://pf.kakao.com/_VmCYn',
href: 'https://pf.kakao.com/_VmCYn',
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/common/layout/sidebar/my-page-sidebar.tsx` at line 106, The
desktop sidebar in MyPageSidebar contains an external link using
"http://pf.kakao.com/_VmCYn"; update that href to use HTTPS
(https://pf.kakao.com/_VmCYn) so it matches the mobile link and is secure, and
scan the MyPageSidebar component for any other occurrences of the same http URL
to replace them as well.

Copy link
Copy Markdown
Contributor Author

@HA-SEUNG-JEONG HA-SEUNG-JEONG May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오톡 링크는 http://pf.kakao.com/_VmCYn가 맞습니다

label: '1:1 문의',
icon: EditNoteIcon,
prefixMatch: true,
},
{
href: '/builder-ticket',
Expand Down Expand Up @@ -138,6 +137,10 @@ export default function Sidebar() {
showToast('준비중인 기능입니다.', 'info');
return;
}
if (item.href.startsWith('http')) {
window.open(item.href, '_blank', 'noopener,noreferrer');
return;
}
router.push(item.href);
}}
isActive={
Expand Down
Loading
Loading