Skip to content

chore: add PHP 8.5 to Github Action #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 28, 2025
Merged

chore: add PHP 8.5 to Github Action #9667

merged 5 commits into from
Aug 28, 2025

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 8, 2025 •
edited by paulbalandan
Loading

Description
See #9664
Closes #9686 as no longer needed

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan reviewed Aug 8, 2025
View reviewed changes
@ddevsr ddevsr mentioned this pull request Aug 8, 2025
Open
16 tasks
@michalsn michalsn added the 4.7 label Aug 14, 2025
@ddevsr ddevsr mentioned this pull request Aug 15, 2025
Closed
5 tasks
@paulbalandan paulbalandan force-pushed the review-php85 branch 3 times, most recently from 2b6c3ae to 8f6e2dd Compare August 27, 2025 19:06
@paulbalandan paulbalandan changed the title chore: added PHP 8.5 to Github Action chore: add PHP 8.5 to Github Action Aug 27, 2025
@paulbalandan paulbalandan added the github_actions Pull requests that update Github_actions code label Aug 27, 2025
michalsn
michalsn approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should drop PHP 8.1 already, since it won't be supported once 4.7 is out. That would reduce the number of checks we run, which is a good thing.

But this looks good, thanks!

@paulbalandan
Copy link
Member

That's what I want to ask too. Will PHP 8.1 be dropped for 4.7 only? or including develop?

@paulbalandan
Copy link
Member

Thank you, @ddevsr

@paulbalandan paulbalandan merged commit 97a5462 into codeigniter4:4.7 Aug 28, 2025
56 checks passed
@michalsn
Copy link
Member

I think we should drop PHP 8.1 starting with 4.7. Since support for 8.1 ends this year, releasing 4.7 in January/February with PHP 8.5 support sounds reasonable.

@ddevsr ddevsr deleted the review-php85 branch August 28, 2025 08:29
@ddevsr ddevsr mentioned this pull request Sep 3, 2025
Merged
5 tasks
@ddevsr
Copy link
Collaborator Author

ddevsr commented Sep 3, 2025

I make PR for minimum PHP 8.2 #9701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.7 github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @paulbalandan @michalsn