-
Notifications
You must be signed in to change notification settings - Fork 2k
chore: bump minimum required PHP 8.2
#9701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rector php sets need to be updated to php82: true Line 56 in 63e9ebd
|
@samsonasik Suggestion change in rector set PHP 8.2 can be split another PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also set up an issue tracking what PHP 8.2 features we can adopt? For one I can think of is the SensitiveParameter
attribute.
See here: CodeIgniter4/phpstan.neon.dist Line 5 in 63e9ebd
and here: CodeIgniter4/system/Debug/Exceptions.php Line 90 in 63e9ebd
Are we changing it? |
Add to https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/changelogs/v4.7.0.rst **********
Highlights
**********
- Update minimal PHP requirement to 8.2. If you wish, you can refresh the versions in the guide: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the rule for readonly
, but when a writeable property appears, you need to return readonly
for the property. We can forget about it.
There are phpstan errors. Okay, we'll fix it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're making these detailed updates, can you also edit warning secion in the README.md
and update the line:
- The end of life date for PHP 8.1 will be December 31, 2025.
as well as add EOL for PHP 8.2? Thanks.
When version release - The end of life date for PHP 8.1 was December 31, 2025.
- The end of life date for PHP 8.2 will be December 31, 2026. |
Thank you @ddevsr |
Description
See #9667 (review)
Checklist: