fix: add universal image to build and push list#329
Merged
Conversation
The universal image was added in #307 but never included in the IMAGES array in scripts/images.sh, so it was never built or pushed to Docker Hub.
The devcontainers/universal base image is amd64-only. Add support for a .platforms file per image directory to override the default multi-arch platform list.
matifali
force-pushed
the
fix/add-universal-to-images
branch
from
936d01d to
c86d5c9
Compare
Member
Author
|
the upstream has no arm64 support: devcontainers/images#1604 |
johnstcn
approved these changes
Apr 10, 2026
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
In future it might be worth investigating if we can make an equivalent image ourselves that has amd64 support.
Member
Author
|
Yeah Thats possible our dogfood image is the closest thing we have already that be repurposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
universalimage was added in #307 but never included in theIMAGESarray inscripts/images.sh. Bothbuild_images.shandpush_images.shiterate over this array, so the universal image was never built or pushed to Docker Hub.Changes
"universal"to theIMAGESarray inscripts/images.sh..platformsfile — if present in the image directory, its content is used as the--platformvalue instead of the default.images/universal/.platformswithlinux/amd64only, sincemcr.microsoft.com/devcontainers/universal:linuxhas no arm64 variant.