Skip to content

fix: add universal image to build and push list #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matifali merged 2 commits into from
Apr 10, 2026
Merged

fix: add universal image to build and push list #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e95797
fix: add universal image to build and push list
matifali Apr 10, 2026
c86d5c9
fix: support per-image platform override, restrict universal to amd64
matifali Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions images/universal/.platforms
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
linux/amd64
10 changes: 9 additions & 1 deletion scripts/build_images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ if [ $QUIET = true ]; then
)
fi

DEFAULT_PLATFORM="linux/amd64,linux/arm64"

for image in "${IMAGES[@]}"; do
image_dir="$PROJECT_ROOT/images/$image"
image_file="${TAG}.Dockerfile"
Expand All @@ -102,7 +104,13 @@ for image in "${IMAGES[@]}"; do
continue
fi

run_trace $DRY_RUN depot build --project "gb3p8xrshk" --load --platform linux/amd64,linux/arm64 --save --metadata-file="build_${image}.json" \
# Allow per-image platform override via a .platforms file.
platform="$DEFAULT_PLATFORM"
if [ -f "$image_dir/.platforms" ]; then
platform=$(cat "$image_dir/.platforms")
fi

run_trace $DRY_RUN depot build --project "gb3p8xrshk" --load --platform "$platform" --save --metadata-file="build_${image}.json" \
"${docker_flags[@]}" \
"$image_dir" \
--file="$image_path" \
Expand Down
1 change: 1 addition & 0 deletions scripts/images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ IMAGES=(
"java"
"node"
"desktop"
"universal"
)