Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies branches #31

Closed
wants to merge 2 commits into from

Conversation

giovanichaves
Copy link

Some dependencies do not have master branch but use the latest version release as default branch
@tkralphs can you kindly merge this ASAP

Some dependencies do not have master branch but use the latest version release as default branch
@CLAassistant
Copy link

CLAassistant commented Dec 6, 2024

CLA assistant check
All committers have signed the CLA.

@giovanichaves
Copy link
Author

@svigerske please check coin-or/coinbrew#100 :)

@tkralphs
Copy link
Member

There is a somewhat long explanation for why ALPS and BiCePS do not use the master branch here while others do, but this is intentional. I would be surprised if building with all master (or perhaps we should say "default"?) branches works. In general, it's OK to allow for not specifying the version of a main project in coinbrew (we can just check out the default branch in that cae, as you suggest), but we can't expect the default branches of all projects to necessarily build together. All dependencies need to be explicitly specified. I'm going to close this PR, but feel free to explain the reason for it and reopen if you like.

@tkralphs tkralphs closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants