Default branch instead of "master"

[giovanichaves]

Some repos default branch are not named "master" so cloning fails if we select branch "master" If "master" is wished, clone should be done without branch selection, so the default branch is selected.

[giovanichaves]

@tkralphs can you merge this one together with coin-or/COIN-OR-OptimizationSuite#31

[giovanichaves]

additionally, when fetching a repo that already exists, if the default branch (indicated by "master" in Dependencies file but might be different) then we should just rebase

[tkralphs]

I'm not sure this is quite the right fix. This fix effectively means that if one specifies the master branch, then one automatically gets whatever the "default" is, whether that is the intention or not. This would be incorrect for projects that do have a master branch, but where that branch is not the default. In such a case, I suppose one might really want master and not the default. So far, I don't think there is such a project, but there may be some soon, as I'm considering changing the default branch of some of my projects to something other than master. I guess there should just be a way of specifying that one wants the "default" branch, whatever it is.

[giovanichaves]

You're correct. I thought about using blank to indicate default branch. But that'd be a bigger hassle to fix the code. So I just hacked this PR together using master to signal the default.

…

On Thu, Dec 19, 2024, 04:31 Ted Ralphs ***@***.***> wrote: I'm not sure this is quite the right fix. This fix effectively means that if one specifies the master branch, then one automatically gets whatever the "default" is, whether that is the intention or not. This would be incorrect for projects that do have a master branch, but where that branch is not the default. In such a case, I suppose one might really want master and not the default. So far, I don't think there is such a project, but there may be some soon, as I'm considering changing the default branch of some of my projects to something other than master. I guess there should just be a way of specifying that one wants the "default" branch, whatever it is. — Reply to this email directly, view it on GitHub <#100 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABQX4B3XSEUHTA6G5MFWHLL2GI4XPAVCNFSM6AAAAABTSAM7NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJSG4YDAOBRGI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[giovanichaves]

Feel free to change or adjust it. I just got fired 2 days ago (2 weeks after I got my first child, 4 days before xmas - simply brutal) so, sadly I have to focus on a new job search

…

On Thu, Dec 19, 2024, 07:47 Giovani Chaves ***@***.***> wrote: You're correct. I thought about using blank to indicate default branch. But that'd be a bigger hassle to fix the code. So I just hacked this PR together using master to signal the default. On Thu, Dec 19, 2024, 04:31 Ted Ralphs ***@***.***> wrote: > I'm not sure this is quite the right fix. This fix effectively means that > if one specifies the master branch, then one automatically gets whatever > the "default" is, whether that is the intention or not. This would be > incorrect for projects that do have a master branch, but where that > branch is not the default. In such a case, I suppose one might really want > master and not the default. So far, I don't think there is such a > project, but there may be some soon, as I'm considering changing the > default branch of some of my projects to something other than master. I > guess there should just be a way of specifying that one wants the "default" > branch, whatever it is. > > — > Reply to this email directly, view it on GitHub > <#100 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABQX4B3XSEUHTA6G5MFWHLL2GI4XPAVCNFSM6AAAAABTSAM7NCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJSG4YDAOBRGI> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

[tkralphs]

Wow, really sorry to hear that!