Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subaru: LKAS_ANGLE support #1781

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

subaru: LKAS_ANGLE support #1781

wants to merge 31 commits into from

Conversation

fredyshox
Copy link
Contributor

@fredyshox fredyshox commented Feb 22, 2025

Harness: Subaru c

Checklist:

  • ES_LKAS_Angle support
  • ES_CruiseControl message for cruise_activated
  • integrate new msgs carstate
  • panda safety model
  • 100% test converage
  • pass safety_replay
  • pass test_car_model / test_car_interfaces
  • reasonable angle limits
  • investigate occasional faults on 90 turns
  • fix shaky wheel at low speed / tune
  • Gen2 angle
  • Angle + long

routes:

  • 08e4c2a99df165b1/00000045--47d798b8be stock lkas + acc
    • includes the system disengaging and 'keep hands on wheel' alerts
  • 08e4c2a99df165b1/0000001c--e76886ecd1 stock with overrides
  • 08e4c2a99df165b1/00000047--6134d3610a on this branch, faults on override

Subaru angle cars:

  • Forester 2022-2024
  • Outback 2023 (gen2)
  • Ascent 2023 (gen2)
  • Crosstrek 2024 (higher trims)?

Previous attempts:
commaai/panda#1533
#1234

@github-actions github-actions bot added car related to opendbc/car/ subaru car safety vehicle-specific safety code labels Feb 22, 2025
@fredyshox fredyshox force-pushed the subaru-angle-commahack branch from b5774cf to 211883a Compare February 22, 2025 07:33
@fredyshox fredyshox force-pushed the subaru-angle-commahack branch from c5ec72e to 2281bed Compare February 24, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code car related to opendbc/car/ DBC signals subaru
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants