fix: Incorrect 500 response for invalid requests #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoenixpereira
changed the title
|
@rohitkrsoni Please run |
phoenixpereira
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix incorrect error handling
Changes Made
Modified get_db() method so that it don't catches any exceptions and let fastapi handle the exceptions.
Changed to HTTPException whereever required
Related Issues
Fixes #65
Additional Notes
When we were handling Exception in get_db(), the HTTPException raised during serving the requests were getting handled by it. Because of the dependency injection, the db is initialised and the session is returned and when the request is served, the execution gets back to the except block and since there was an http exception raised, it was getting handled there.