Skip to content

TMT: re-enable podman e2e revdep tests #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 26, 2025

We need to run podman e2e tests as they are not the same as system tests.
For example: podman container restore --pod ... test isn't run in the system tests and this test is currently failing on RHEL.

This reverts commit 3f2d85a and makes additional changes to suit current state.

Summary by Sourcery

Re-enable Podman E2E revdep tests by revamping the test script to fetch the latest source RPM, support separate 'e2e' and 'system' modes, and add Makefile automation for SELinux, E2E, and system tests.

Enhancements:

  • Support selecting 'e2e' or 'system' test modes in podman-tests.sh with usage guidance
  • Automatically remove conflicting repos, fetch, and extract the latest Podman source RPM for testing
  • Adjust package queries and environment variables (TMPDIR, SELinux modules) for reliable test execution
  • Introduce Makefile targets for basic SELinux checks, podman_e2e_test, and podman_system_test

Tests:

  • Run Go-based E2E tests in the Podman source tree when invoked with 'e2e'
  • Execute bats-based system tests for checkpoint and SELinux scenarios when invoked with 'system'

Copy link

sourcery-ai bot commented May 26, 2025

Reviewer's Guide

Re-enables Podman e2e revdep tests by parameterizing the test script to fetch and extract the latest Podman source, selectively running Go-based e2e or Bats-based system tests, and introduces a Makefile for streamlined test orchestration.

File-Level Changes

Change Details Files
Parameterize podman-tests.sh to support e2e and system tests and fetch upstream sources
  • Added TEST_TYPE argument parsing and usage message
  • Cleaned conflicting repos and updated rpm -q package list
  • Dynamically download SRPM via dnf/dnf5 and extract Podman sources
  • Conditional branches to run Go-based e2e tests or Bats system tests
test/podman-tests.sh
Add Makefile with phony targets for test workflows
  • Introduced basic_check, podman_e2e_test, podman_system_test, and clean targets
  • Wired targets to invoke podman-tests.sh with the correct mode
test/Makefile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

openshift-ci bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 force-pushed the podman-e2e-reenable branch 8 times, most recently from 43af1d2 to 7389a9a Compare May 27, 2025 18:25
We need to run podman e2e tests as they are not the same as system
tests.
For example: `podman container restore --pod ...` test isn't run in the
system tests and this test is currently failing on RHEL.

This reverts commit 3f2d85a and makes
additional changes to suit current state.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the podman-e2e-reenable branch from 7389a9a to 87e53a2 Compare May 28, 2025 12:50
lsm5 added 5 commits May 28, 2025 09:21
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

/packit retest-failed containers/podman#26234

@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

/packit build
/packit test

@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

/packit build
/packit test containers/podman#26234

@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

/packit test containers/podman#26234

@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

/packit test containers/podman#26234

Won't work if we need to fetch sources. Anyway, the tests will be skipped once the podman PR is merged. So, that issue can be ignored for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant