-
Notifications
You must be signed in to change notification settings - Fork 2.7k
e2e: skip pre-checkpoint tests on aarch64 #26234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: skip pre-checkpoint tests on aarch64 #26234
Conversation
I'll verify if the tests are skipped correctly on containers/container-selinux#378 |
Per Adrian Reber, the aarch64 kernel doesn't support the soft dirty bit and support isn't expected anytime soon. Ref: checkpoint-restore/criu#2676 Signed-off-by: Lokesh Mandvekar <[email protected]>
3880396
to
5e7c0a6
Compare
This won't work if we need to fetch sources as is the case with e2e test runs. I've verified the tests are skipped on a testing farm aarch64 instance. Opening for review. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -977,6 +977,9 @@ var _ = Describe("Podman checkpoint", func() { | |||
}) | |||
|
|||
It("podman checkpoint container with --pre-checkpoint", func() { | |||
if podmanTest.Host.Arch == "arm64" { | |||
Skip("skip on arm64/aarch64, checkpoint-restore/criu GH issue #2676") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could as well put the full URL here instead so users don't have to manually look it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even better yes. I'll do a followup.
btw, long term it'd be even better to implement Adrian's suggestion of checking for criu's supported feature set on the arch and skipping based on that.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Followup on containers#26234. Signed-off-by: Lokesh Mandvekar <[email protected]>
Per Adrian Reber, the aarch64 kernel doesn't support the soft dirty bit and support isn't expected anytime soon.
Ref: checkpoint-restore/criu#2676
Does this PR introduce a user-facing change?