Skip to content

e2e: skip pre-checkpoint tests on aarch64 #26234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 29, 2025

Per Adrian Reber, the aarch64 kernel doesn't support the soft dirty bit and support isn't expected anytime soon.

Ref: checkpoint-restore/criu#2676

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2025
@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

I'll verify if the tests are skipped correctly on containers/container-selinux#378

Per Adrian Reber, the aarch64 kernel doesn't support the soft dirty bit
and support isn't expected anytime soon.

Ref: checkpoint-restore/criu#2676

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the pre-checkpoint-skip-aarch64 branch from 3880396 to 5e7c0a6 Compare May 29, 2025 16:25
@lsm5
Copy link
Member Author

lsm5 commented May 29, 2025

I'll verify if the tests are skipped correctly on containers/container-selinux#378

This won't work if we need to fetch sources as is the case with e2e test runs. I've verified the tests are skipped on a testing farm aarch64 instance. Opening for review.

@lsm5 lsm5 marked this pull request as ready for review May 29, 2025 18:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2025
@mheon
Copy link
Member

mheon commented May 29, 2025

LGTM

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -977,6 +977,9 @@ var _ = Describe("Podman checkpoint", func() {
})

It("podman checkpoint container with --pre-checkpoint", func() {
if podmanTest.Host.Arch == "arm64" {
Skip("skip on arm64/aarch64, checkpoint-restore/criu GH issue #2676")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could as well put the full URL here instead so users don't have to manually look it up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better yes. I'll do a followup.

btw, long term it'd be even better to implement Adrian's suggestion of checking for criu's supported feature set on the arch and skipping based on that.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2025
Copy link
Contributor

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 82fcf45 into containers:main May 30, 2025
53 checks passed
lsm5 added a commit to lsm5/podman that referenced this pull request May 30, 2025
@lsm5 lsm5 deleted the pre-checkpoint-skip-aarch64 branch May 30, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants